feat: wire navigation and jump list into the book viewer #26
+114
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- App: index state with bounds-safe clamping, NavigationControls (prev/next) and BookJumpList (direct selection via onSelect) rendered inside the book viewer region - tests: navigation changes the displayed book and position text, jump selection works, and the fetch counter stays at 1 across prev/next and jump interactions (no unnecessary API calls) - App snapshot updated deliberately (viewer now includes both controls) Completes #12: BookCard, NavigationControls and BookJumpList are now wired together — the issue's remaining scope.
erikhfj
added
type: feature
rachelks
previously approved these changes
Sep 9, 2026
robertky
approved these changes
Sep 10, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes #12 — the final wiring (per review agreement, the issue stays open until this lands):
Appnow holds the book index with bounds-safe clamping (safeIndex), so a stale index can never point outside the listNavigationControls(prev/next) andBookJumpList(direct selection) rendered in the book viewer regionfantasyuntil then)Tests (3 new, 26 total green)
selectOptionson the labeled select)vitest -u) — viewer now includes both controlsChecklist
npm run lint— 0 warningsnpm test— 26 passednpm run build— passesnpm run format:check— passesAI-assisted: implementation generated with AI assistance, reviewed and verified.